Michal Skrivanek has posted comments on this change.
Change subject: engine: Integrate noVNC support
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java
Line 358: return clientOsType().equalsIgnoreCase("Linux") &&
clientBrowserType().equalsIgnoreCase("Firefox"); //$NON-NLS-1$ //$NON-NLS-2$
Line 359: }
Line 360:
Line 361: public boolean isClientWindowExplorerWithWebsockets() {
Line 362: return isClientWindowsExplorer(); //TODO add check for ie 10
most browser have some kind of support, but not really up to the standard so
even if there is a way how to find out, I'd rather use a compatibility matrix.
IIUC currently from browsers we do support in UP and WA only IE<10 doesn't work.
Line 363: }
Line 364:
Line 365: public boolean isClientWindowsExplorer() {
Line 366: return isClientWindows() &&
clientBrowserType().equalsIgnoreCase("Explorer"); //$NON-NLS-1$ //$NON-NLS-2$
--
To view, visit http://gerrit.ovirt.org/13931
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44e9870b88537360a1886e89c08f18865eae2ef0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Martin Beták <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
