Shahar Havivi has uploaded a new change for review. Change subject: findbugs: use Boolean.valueOf instead of Boolean constructor ......................................................................
findbugs: use Boolean.valueOf instead of Boolean constructor Change-Id: I114592d410251a6d51eee79cb3c63fa3a2936e54 Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CopyImageVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DeleteImageGroupVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MergeSnapshotsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MoveImageGroupVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStartVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmLogoffVDSCommand.java 7 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/23/14123/1 diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java index 6ab9826..04b8852 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java @@ -161,7 +161,7 @@ _writer.WriteAttributeString(OVF_URI, "disk-description", image.getDiskDescription()); } _writer.WriteAttributeString(OVF_URI, "wipe-after-delete", - (new Boolean(image.isWipeAfterDelete())).toString()); + (Boolean.valueOf(image.isWipeAfterDelete())).toString()); _writer.WriteEndElement(); } _writer.WriteEndElement(); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CopyImageVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CopyImageVDSCommand.java index a4e8267..9f9f674 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CopyImageVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CopyImageVDSCommand.java @@ -45,8 +45,8 @@ getParameters().getCopyVolumeType().getValue(), getParameters().getVolumeFormat().getValue(), getParameters().getPreallocate().getValue(), - (new Boolean(getParameters().getPostZero())).toString().toLowerCase(), - (new Boolean(getParameters().getForce())).toString().toLowerCase()); + (Boolean.valueOf(getParameters().getPostZero())).toString().toLowerCase(), + (Boolean.valueOf(getParameters().getForce())).toString().toLowerCase()); ProceedProxyReturnValue(); Guid taskID = new Guid(uuidReturn.mUuid); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DeleteImageGroupVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DeleteImageGroupVDSCommand.java index f1550b2..02aa189 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DeleteImageGroupVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DeleteImageGroupVDSCommand.java @@ -15,8 +15,8 @@ getIrsProxy().deleteImage(getParameters().getStorageDomainId().toString(), getParameters().getStoragePoolId().toString(), getParameters().getImageGroupId().toString(), - (new Boolean(getParameters().getPostZeros())).toString(), - (new Boolean(getParameters().getForceDelete())).toString().toLowerCase()); + (Boolean.valueOf(getParameters().getPostZeros())).toString(), + (Boolean.valueOf(getParameters().getForceDelete())).toString().toLowerCase()); ProceedProxyReturnValue(); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MergeSnapshotsVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MergeSnapshotsVDSCommand.java index 28c4aad..fbba35d 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MergeSnapshotsVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MergeSnapshotsVDSCommand.java @@ -19,7 +19,7 @@ getParameters().getImageGroupId().toString(), getParameters().getImageId().toString(), getParameters().getImageId2().toString(), - (new Boolean(getParameters().getPostZero())).toString().toLowerCase()); + (Boolean.valueOf(getParameters().getPostZero())).toString().toLowerCase()); ProceedProxyReturnValue(); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MoveImageGroupVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MoveImageGroupVDSCommand.java index 9f1c150..aa42e40 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MoveImageGroupVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MoveImageGroupVDSCommand.java @@ -18,8 +18,8 @@ getParameters().getImageGroupId().toString(), getParameters().getVmId().toString(), getParameters().getOp().getValue(), - (new Boolean(getParameters().getPostZero())).toString().toLowerCase(), - (new Boolean(getParameters().getForce())).toString().toLowerCase()); + (Boolean.valueOf(getParameters().getPostZero())).toString().toLowerCase(), + (Boolean.valueOf(getParameters().getForce())).toString().toLowerCase()); ProceedProxyReturnValue(); Guid taskID = new Guid(uuidReturn.mUuid); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStartVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStartVDSCommand.java index 935378d..cf22d95 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStartVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStartVDSCommand.java @@ -26,7 +26,7 @@ _result = getBroker().spmStart(getParameters().getStoragePoolId().toString(), getParameters().getPrevId(), getParameters().getPrevLVER(), getParameters().getRecoveryMode().getValue(), - (new Boolean(getParameters().getSCSIFencing())).toString().toLowerCase(), + (Boolean.valueOf(getParameters().getSCSIFencing())).toString().toLowerCase(), Config.<Integer> GetValue(ConfigValues.MaxNumberOfHostsInStoragePool), getParameters().getStoragePoolFormatType().getValue()); ProceedProxyReturnValue(); Guid taskId = new Guid(_result.mUuid); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmLogoffVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmLogoffVDSCommand.java index fb7078c..ae224bb 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmLogoffVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmLogoffVDSCommand.java @@ -15,7 +15,7 @@ @Override protected void ExecuteVdsBrokerCommand() { - status = getBroker().desktopLogoff(mVmId.toString(), (new Boolean(mForce)).toString()); + status = getBroker().desktopLogoff(mVmId.toString(), (Boolean.valueOf(mForce)).toString()); ProceedProxyReturnValue(); } } -- To view, visit http://gerrit.ovirt.org/14123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I114592d410251a6d51eee79cb3c63fa3a2936e54 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
