Allon Mureinik has posted comments on this change.
Change subject: findbugs: use Boolean.valueOf instead of Boolean constructor
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(10 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
Line 160: if (image.getDiskDescription() != null) {
Line 161: _writer.WriteAttributeString(OVF_URI,
"disk-description", image.getDiskDescription());
Line 162: }
Line 163: _writer.WriteAttributeString(OVF_URI, "wipe-after-delete",
Line 164:
(Boolean.valueOf(image.isWipeAfterDelete())).toString());
Instead of using Boolean.valueOf(boolean).toString(), just use
String.valueOf(boolean)
Line 165: _writer.WriteEndElement();
Line 166: }
Line 167: _writer.WriteEndElement();
Line 168: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CopyImageVDSCommand.java
Line 44:
getParameters().getDstStorageDomainId().toString(),
Line 45:
getParameters().getCopyVolumeType().getValue(),
Line 46:
getParameters().getVolumeFormat().getValue(),
Line 47:
getParameters().getPreallocate().getValue(),
Line 48:
(Boolean.valueOf(getParameters().getPostZero())).toString().toLowerCase(),
Instead of using Boolean.valueOf(boolean).toString(), just use
String.valueOf(boolean)
Line 49:
(Boolean.valueOf(getParameters().getForce())).toString().toLowerCase());
Line 50: ProceedProxyReturnValue();
Line 51:
Line 52: Guid taskID = new Guid(uuidReturn.mUuid);
Line 45:
getParameters().getCopyVolumeType().getValue(),
Line 46:
getParameters().getVolumeFormat().getValue(),
Line 47:
getParameters().getPreallocate().getValue(),
Line 48:
(Boolean.valueOf(getParameters().getPostZero())).toString().toLowerCase(),
Line 49:
(Boolean.valueOf(getParameters().getForce())).toString().toLowerCase());
Instead of using Boolean.valueOf(boolean).toString(), just use
String.valueOf(boolean)
Line 50: ProceedProxyReturnValue();
Line 51:
Line 52: Guid taskID = new Guid(uuidReturn.mUuid);
Line 53:
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DeleteImageGroupVDSCommand.java
Line 14: uuidReturn =
Line 15:
getIrsProxy().deleteImage(getParameters().getStorageDomainId().toString(),
Line 16:
getParameters().getStoragePoolId().toString(),
Line 17:
getParameters().getImageGroupId().toString(),
Line 18:
(Boolean.valueOf(getParameters().getPostZeros())).toString(),
Instead of using Boolean.valueOf(boolean).toString(), just use
String.valueOf(boolean)
Line 19:
(Boolean.valueOf(getParameters().getForceDelete())).toString().toLowerCase());
Line 20:
Line 21: ProceedProxyReturnValue();
Line 22:
Line 15:
getIrsProxy().deleteImage(getParameters().getStorageDomainId().toString(),
Line 16:
getParameters().getStoragePoolId().toString(),
Line 17:
getParameters().getImageGroupId().toString(),
Line 18:
(Boolean.valueOf(getParameters().getPostZeros())).toString(),
Line 19:
(Boolean.valueOf(getParameters().getForceDelete())).toString().toLowerCase());
Instead of using Boolean.valueOf(boolean).toString(), just use
String.valueOf(boolean)
Line 20:
Line 21: ProceedProxyReturnValue();
Line 22:
Line 23: Guid taskID = new Guid(uuidReturn.mUuid);
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MergeSnapshotsVDSCommand.java
Line 19:
getParameters().getImageGroupId().toString(),
Line 20:
getParameters().getImageId().toString(),
Line 21:
getParameters().getImageId2().toString(),
Line 22:
(Boolean.valueOf(getParameters().getPostZero())).toString().toLowerCase());
Line 23:
Instead of using Boolean.valueOf(boolean).toString(), just use
String.valueOf(boolean)
Line 24: ProceedProxyReturnValue();
Line 25:
Line 26: Guid taskID = new Guid(uuidReturn.mUuid);
Line 27:
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MoveImageGroupVDSCommand.java
Line 17:
getParameters().getDstDomainId().toString(),
Line 18:
getParameters().getImageGroupId().toString(),
Line 19:
getParameters().getVmId().toString(),
Line 20:
getParameters().getOp().getValue(),
Line 21:
(Boolean.valueOf(getParameters().getPostZero())).toString().toLowerCase(),
Instead of using Boolean.valueOf(boolean).toString(), just use
String.valueOf(boolean)
Line 22:
(Boolean.valueOf(getParameters().getForce())).toString().toLowerCase());
Line 23: ProceedProxyReturnValue();
Line 24:
Line 25: Guid taskID = new Guid(uuidReturn.mUuid);
Line 18:
getParameters().getImageGroupId().toString(),
Line 19:
getParameters().getVmId().toString(),
Line 20:
getParameters().getOp().getValue(),
Line 21:
(Boolean.valueOf(getParameters().getPostZero())).toString().toLowerCase(),
Line 22:
(Boolean.valueOf(getParameters().getForce())).toString().toLowerCase());
Instead of using Boolean.valueOf(boolean).toString(), just use
String.valueOf(boolean)
Line 23: ProceedProxyReturnValue();
Line 24:
Line 25: Guid taskID = new Guid(uuidReturn.mUuid);
Line 26:
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStartVDSCommand.java
Line 25: protected void ExecuteVdsBrokerCommand() {
Line 26: _result =
getBroker().spmStart(getParameters().getStoragePoolId().toString(),
Line 27: getParameters().getPrevId(),
getParameters().getPrevLVER(),
Line 28: getParameters().getRecoveryMode().getValue(),
Line 29:
(Boolean.valueOf(getParameters().getSCSIFencing())).toString().toLowerCase(),
Instead of using Boolean.valueOf(boolean).toString(), just use
String.valueOf(boolean)
Line 30: Config.<Integer>
GetValue(ConfigValues.MaxNumberOfHostsInStoragePool),
getParameters().getStoragePoolFormatType().getValue());
Line 31: ProceedProxyReturnValue();
Line 32: Guid taskId = new Guid(_result.mUuid);
Line 33:
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmLogoffVDSCommand.java
Line 14: }
Line 15:
Line 16: @Override
Line 17: protected void ExecuteVdsBrokerCommand() {
Line 18: status = getBroker().desktopLogoff(mVmId.toString(),
(Boolean.valueOf(mForce)).toString());
Instead of using Boolean.valueOf(boolean).toString(), just use
String.valueOf(boolean)
Line 19: ProceedProxyReturnValue();
Line 20: }
--
To view, visit http://gerrit.ovirt.org/14123
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I114592d410251a6d51eee79cb3c63fa3a2936e54
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
