Shahar Havivi has uploaded a new change for review. Change subject: findbugs: Method invokes inefficient new String constructor ......................................................................
findbugs: Method invokes inefficient new String constructor Change-Id: Iead8eb1db18c8d08e536f27b03e1f3adb25c89d9 Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartsImplTest.java 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/24/14124/1 diff --git a/backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartsImplTest.java b/backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartsImplTest.java index d1e3014..69b7f16 100644 --- a/backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartsImplTest.java +++ b/backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartsImplTest.java @@ -271,7 +271,7 @@ inputType[0] = String.class; Object[] input = new Object[1]; - input[0] = new String("livnat"); + input[0] = "livnat"; Method methodToRun = job.getClass().getDeclaredMethod(methodName, inputType); @@ -293,7 +293,7 @@ inputType[1] = Integer.class; Object[] input = new Object[2]; - input[0] = new String("msg1"); + input[0] = "msg1"; input[1] = new Integer(5); scheduler.scheduleAOneTimeJob(pj, "onTimerWithParam", inputType, input, 1, TimeUnit.MILLISECONDS); try { @@ -320,7 +320,7 @@ inputType[1] = int.class; Object[] input = new Object[2]; - input[0] = new String("msg1"); + input[0] = "msg1"; input[1] = 5; scheduler.scheduleAFixedDelayJob(pj, "onTimerWithParam", inputType, input, 1, 1, TimeUnit.MILLISECONDS); try { -- To view, visit http://gerrit.ovirt.org/14124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iead8eb1db18c8d08e536f27b03e1f3adb25c89d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
