Omer Frenkel has posted comments on this change.
Change subject: core: Update VM status if host is not available
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
Line 85:
Line 86: @Override
Line 87: protected void handleNonRespondingTreatmentFailure() {
Line 88: HandleError();
Line 89: AlertIfPowerManagementOperationSkipped(RESTART);
looks like this method (AlertIf...) already called inside HandleError method
(last line there)
if i'm right, maybe this method (handleNonRespondingTreatmentFailure) is not
needed at all? and only HandleError (as it used to be)
Line 90: };
Line 91:
Line 92: /**
Line 93: * Determine if the status is legal for actually fence the VDS.
--
To view, visit http://gerrit.ovirt.org/13706
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If569de776dfb9c97589603040e7a7f620409c361
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Libor Spevak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
