Omer Frenkel has posted comments on this change.

Change subject: core: Update VM status if host is not available
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 628:             AuditLogDirector.log(logable, AuditLogType.VDS_FAILURE);
Line 629:             
ResourceManager.getInstance().getEventListener().vdsNotResponding(vds);
Line 630: 
Line 631:             // update VMs states running on the host to unknown
Line 632:             moveVMsToUnknown();
why this is needed here? i think it happens automatically in non responsive 
treatment command
Line 633:         }
Line 634:         return true;
Line 635:     }
Line 636: 


....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 1508:                     vmToUpdate.getStatus().name(),
Line 1509:                     runningVm.getStatus().name());
Line 1510: 
Line 1511:             if (vmToUpdate.getStatus() == VMStatus.Unknown) {
Line 1512:                 logVmStatusTransionFromUnknown(vmToUpdate, 
runningVm);
isn't there an event fired when vm moves to up?
Line 1513:             }
Line 1514:         }
Line 1515:     }
Line 1516: 


--
To view, visit http://gerrit.ovirt.org/13706
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If569de776dfb9c97589603040e7a7f620409c361
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to