Laszlo Hornyak has posted comments on this change.
Change subject: engine: TmeoutBase - Improving memory footprint - continue
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBase.java
Line 50: public boolean getLegal() {
Line 51: if (getUseTimout()) {
Line 52: String keyForCheck = getkeyForCheck();
Line 53: if
(CacheManager.getTimeoutBaseCache().putIfAbsent(keyForCheck,
Line 54: keyForCheck,
looks good, I didn't quite understand why we put TimeoutBase (mostly command
objects) in the cache
but where are you going to read this?
Line 55: getEndTime(),
Line 56: TimeUnit.MILLISECONDS) == null) {
Line 57: return true;
Line 58: }
--
To view, visit http://gerrit.ovirt.org/14158
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I795019a35a57fef688296d9f1083bc77c9272bc7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
