Michael Kublin has posted comments on this change.
Change subject: engine: TmeoutBase - Improving memory footprint - continue
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBase.java
Line 50: public boolean getLegal() {
Line 51: if (getUseTimout()) {
Line 52: String keyForCheck = getkeyForCheck();
Line 53: if
(CacheManager.getTimeoutBaseCache().putIfAbsent(keyForCheck,
Line 54: keyForCheck,
No, it is used only as place holder, when key is not in cache we should write
TimeoutBase to DB
Line 55: getEndTime(),
Line 56: TimeUnit.MILLISECONDS) == null) {
Line 57: return true;
Line 58: }
....................................................
Commit Message
Line 3: AuthorDate: 2013-04-23 11:03:35 +0300
Line 4: Commit: Michael Kublin <[email protected]>
Line 5: CommitDate: 2013-04-23 11:03:35 +0300
Line 6:
Line 7: engine: TmeoutBase - Improving memory footprint - continue
Done
Line 8:
Line 9: After changes inside TimeoutBase, I found out that the cache is used
only as place holder,
Line 10: so instead of putting TimeouBase object to cache I decided to put
String, also possible to put
Line 11: some king const Object but, I think it is not make any difference
--
To view, visit http://gerrit.ovirt.org/14158
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I795019a35a57fef688296d9f1083bc77c9272bc7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
