Allon Mureinik has posted comments on this change.
Change subject: core: InitVdsOnUp- proceed regardless of
ConnectHostToStoragePoolServers
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java
Line 19: * considering that connection failed only if data domains failed to
connect. If
Line 20: * Iso/Export domains failed to connect - only log it.
Line 21: */
Line 22: @NonTransactiveCommandAttribute
Line 23: public class ConnectHostToStoragePoolServersCommand extends
IMHO logging manually is a better approach, since conceptually this command is
indeed internal, but let's see what mkublin thinks.
Line 24:
ConnectHostToStoragePooServerCommandBase<HostStoragePoolParametersBase> {
Line 25:
Line 26: public
ConnectHostToStoragePoolServersCommand(HostStoragePoolParametersBase
parameters) {
Line 27: super(parameters);
--
To view, visit http://gerrit.ovirt.org/13880
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia69b62807331d4a47482f71fe88aa3e2ad7b7448
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
