Michael Kublin has posted comments on this change.
Change subject: core: InitVdsOnUp- proceed regardless of
ConnectHostToStoragePoolServers
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
Bad auditlog events, mean patch contains a bug . Can not be merged
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 136: returnValue = true;
Line 137: _connectPoolSucceeded = true;
Line 138: } else {
Line 139: HostStoragePoolParametersBase params = new
HostStoragePoolParametersBase(getStoragePool(), getVds());
Line 140:
Backend.getInstance().runInternalAction(VdcActionType.ConnectHostToStoragePoolServers,
params);
_connectPoolSucceeded = connectHostToPool(); - this is to big change for patch ?
Line 141: returnValue = connectHostToPool();
Line 142: _connectPoolSucceeded = returnValue;
Line 143: }
Line 144: return returnValue;
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java
Line 49: }
Line 50:
Line 51: @Override
Line 52: public AuditLogType getAuditLogTypeValue() {
Line 53: return getSucceeded() ? AuditLogType.UNASSIGNED :
AuditLogType.CONNECT_STORAGE_SERVERS_FAILED;
AuditLogType.UNASSIGNED - really?
Line 54: }
Line 55:
Line 56: private boolean connectStorageServer(StorageType type,
List<StorageServerConnections> connections) {
Line 57: boolean connectSucceeded = true;
--
To view, visit http://gerrit.ovirt.org/13880
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia69b62807331d4a47482f71fe88aa3e2ad7b7448
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
