Alona Kaplan has uploaded a new change for review.

Change subject: webdamin: make the right side of vm->interface sub tab resizable
......................................................................

webdamin: make the right side of vm->interface sub tab resizable

Make the columns of the statistics and guest agent tabs (which are based
on EntityModelCellTable) resizable.

Change-Id: Ic7b36139e522abe7805a8b09d803d06e6a87e685
Signed-off-by: Alona Kaplan <[email protected]>
---
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceInfoPanel.java
2 files changed, 14 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/66/14366/1

diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java
index e41c97b..e357599 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java
@@ -304,6 +304,11 @@
         super.addColumn(column, headerHtml);
     }
 
+    public void addColumn(Column column, SafeHtml headerHtml, String width) {
+        super.addColumnWithHtmlHeader(column, headerHtml.asString());
+        super.setColumnWidth(column, width);
+    }
+
     @Override
     public void addColumn(Column column, String headerString, String width) {
         super.addColumn(column, headerString);
diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceInfoPanel.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceInfoPanel.java
index 8479251..34ca499 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceInfoPanel.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceInfoPanel.java
@@ -81,6 +81,7 @@
 
     private void initStatitsticsTable() {
         statisticsTable = new EntityModelCellTable<ListModel>(false, true);
+        statisticsTable.enableColumnResizing();
 
         TextColumnWithTooltip<VmNetworkInterface> rxColumn = new 
RxTxRateColumn<VmNetworkInterface>() {
             @Override
@@ -99,7 +100,7 @@
         };
 
         statisticsTable.addColumn(rxColumn,
-                templates.sub(constants.rxInterface(), constants.mbps()));
+                templates.sub(constants.rxInterface(), constants.mbps()), 
"150px"); //$NON-NLS-1$
 
         TextColumnWithTooltip<VmNetworkInterface> txColumn = new 
RxTxRateColumn<VmNetworkInterface>() {
             @Override
@@ -118,7 +119,7 @@
         };
 
         statisticsTable.addColumn(txColumn,
-                templates.sub(constants.txInterface(), constants.mbps()));
+                templates.sub(constants.txInterface(), constants.mbps()), 
"150px"); //$NON-NLS-1$
 
         TextColumnWithTooltip<VmNetworkInterface> dropsColumn = new 
SumUpColumn<VmNetworkInterface>() {
             @Override
@@ -128,7 +129,7 @@
             }
         };
         statisticsTable.addColumn(dropsColumn,
-                templates.sub(constants.dropsInterface(), constants.pkts()));
+                templates.sub(constants.dropsInterface(), constants.pkts()), 
"150px"); //$NON-NLS-1$
 
         statisticsTable.setRowData(new ArrayList<EntityModel>());
         statisticsTable.setWidth("100%", true); //$NON-NLS-1$
@@ -137,6 +138,7 @@
 
     private void initGuestAgentDataTable() {
         guestAgentDataTable = new EntityModelCellTable<ListModel>(false, true);
+        guestAgentDataTable.enableColumnResizing();
 
         TextColumnWithTooltip<VmGuestAgentInterface> nameColumn = new 
TextColumnWithTooltip<VmGuestAgentInterface>() {
 
@@ -147,7 +149,7 @@
 
         };
         guestAgentDataTable.addColumn(nameColumn,
-                constants.nameVmGuestAgent());
+                constants.nameVmGuestAgent(), "150px"); //$NON-NLS-1$
 
         SafeHtmlWithSafeHtmlTooltipColumn<VmGuestAgentInterface> ipv4Column =
                 new SafeHtmlWithSafeHtmlTooltipColumn<VmGuestAgentInterface>() 
{
@@ -172,7 +174,7 @@
                     }
                 };
         guestAgentDataTable.addColumn(ipv4Column,
-                constants.ipv4VmGuestAgent());
+                constants.ipv4VmGuestAgent(), "150px"); //$NON-NLS-1$
 
         SafeHtmlWithSafeHtmlTooltipColumn<VmGuestAgentInterface> ipv6Column =
                 new SafeHtmlWithSafeHtmlTooltipColumn<VmGuestAgentInterface>() 
{
@@ -198,7 +200,7 @@
                 };
 
         guestAgentDataTable.addColumn(ipv6Column,
-                constants.ipv6VmGuestAgent());
+                constants.ipv6VmGuestAgent(), "200px"); //$NON-NLS-1$
 
         TextColumnWithTooltip<VmGuestAgentInterface> macColumn = new 
TextColumnWithTooltip<VmGuestAgentInterface>() {
 
@@ -209,7 +211,7 @@
 
         };
         guestAgentDataTable.addColumn(macColumn,
-                constants.macVmGuestAgent());
+                constants.macVmGuestAgent(), "150px"); //$NON-NLS-1$
 
         guestAgentDataTable.setRowData(new ArrayList<EntityModel>());
         guestAgentDataTable.setWidth("100%", true); //$NON-NLS-1$


--
To view, visit http://gerrit.ovirt.org/14366
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7b36139e522abe7805a8b09d803d06e6a87e685
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to