Vojtech Szocs has posted comments on this change. Change subject: webdamin: make the right side of vm->interface sub tab resizable ......................................................................
Patch Set 3: Looks good to me, approved Rebased and updated: Added 'EntityModelCellTable.addColumn(Column,SafeHtml,String)' method without generic Column signature - this is necessary because the caller (VmInterfaceInfoPanel) doesn't provide correct Column signature - can be fixed later on: * column is Column<VmNetworkInterface> (statisticsTable) or Column<VmGuestAgentInterface> (guestAgentDataTable) * both statisticsTable and guestAgentDataTable is CellTable<ListModel> * statisticsTable should be CellTable<VmNetworkInterface> and guestAgentDataTable should be CellTable<VmGuestAgentInterface> Gave +2 review, Alona can you please re-verify? :) -- To view, visit http://gerrit.ovirt.org/14366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7b36139e522abe7805a8b09d803d06e6a87e685 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
