Shireesh Anjal has posted comments on this change.
Change subject: engine: Gluster hook content query
......................................................................
Patch Set 6: (1 inline comment)
Looks good. One suggestion in-line for adding not-null check on the hook-id
parameter.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterHookQueryParameters.java
Line 9: */
Line 10: public class GlusterHookQueryParameters extends VdcQueryParametersBase
{
Line 11: private static final long serialVersionUID = 4564573475511998657L;
Line 12:
Line 13: private Guid glusterHookId;
You can add a @NotNull annotation on this field, so that a proper error is set
when passed as null.
Line 14:
Line 15: private Guid glusterServerId = null;
Line 16:
Line 17: public GlusterHookQueryParameters(Guid glusterHookId) {
--
To view, visit http://gerrit.ovirt.org/12219
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie24d1132fc214661cd2c2e3071f641812d19cd4f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
