Kanagaraj M has posted comments on this change.
Change subject: engine: Gluster hook content query
......................................................................
Patch Set 9: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterHookContentQuery.java
Line 37:
Line 38: if (hook.getContentType().equals(GlusterHookContentType.TEXT))
{
Line 39: content =
StringUtils.newStringUtf8(Base64.decodeBase64(content));
Line 40: }
Line 41: getQueryReturnValue().setReturnValue(content);
Empty content should be returned if content type is BINARY. So in the beginning
of the method itself you can check the content type and return an empty string.
Line 42: }
Line 43:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterHookQueryParameters.java
Line 8: /**
Line 9: * Parameter class with Gluster Hook Id and Host Id as parameters. <br>
Line 10: * This will be used by Gluster Hook Content query. <br>
Line 11: */
Line 12: public class GlusterHookQueryParameters extends VdcQueryParametersBase
{
Please rename this to GlusterHookContentQueryParameters
Line 13: private static final long serialVersionUID = 4564573475511998657L;
Line 14:
Line 15: @NotNull(message = "VALIDATION.GLUSTER.GLUSTER_HOOK_ID.NOT_NULL")
Line 16: private Guid glusterHookId;
--
To view, visit http://gerrit.ovirt.org/12219
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie24d1132fc214661cd2c2e3071f641812d19cd4f
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
