Laszlo Hornyak has uploaded a new change for review. Change subject: engine: search remove redundant constructor param (2/N) ......................................................................
engine: search remove redundant constructor param (2/N) Removed a parameter from AutoCompletionField constructor, it was practically always equal to another parameter. Change-Id: I28129e1549232ba33db8b91ed9c5bd8061ad24f2 Signed-off-by: Laszlo Hornyak <[email protected]> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/gluster/GlusterVolumeConditionFieldAutoCompleter.java 1 file changed, 3 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/05/14405/1 diff --git a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/gluster/GlusterVolumeConditionFieldAutoCompleter.java b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/gluster/GlusterVolumeConditionFieldAutoCompleter.java index 2b21933..36b5bf6 100644 --- a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/gluster/GlusterVolumeConditionFieldAutoCompleter.java +++ b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/gluster/GlusterVolumeConditionFieldAutoCompleter.java @@ -93,13 +93,13 @@ } private static void addField(String fieldName, Class<?> fieldType, String columnName) { - fields.add(new AutoCompletionField(fieldName, fieldName, fieldType, columnName)); + fields.add(new AutoCompletionField(fieldName, fieldType, columnName)); } private void buildDictionaries() { // Build the field name auto completion dictionary for (AutoCompletionField field : fields) { - mVerbs.put(field.fieldName, field.displayName); + mVerbs.put(field.fieldName, field.fieldName); } buildCompletions(); @@ -119,13 +119,11 @@ private static final class AutoCompletionField { protected final String fieldName; - protected final String displayName; protected final Class<?> fieldType; protected final String columnName; - public AutoCompletionField(String fieldName, String displayName, Class<?> fieldType, String columnName) { + public AutoCompletionField(String fieldName, Class<?> fieldType, String columnName) { this.fieldName = fieldName; - this.displayName = displayName; this.fieldType = fieldType; this.columnName = columnName; } -- To view, visit http://gerrit.ovirt.org/14405 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I28129e1549232ba33db8b91ed9c5bd8061ad24f2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
