Shireesh Anjal has posted comments on this change. Change subject: engine: search remove redundant constructor param (2/N) ......................................................................
Patch Set 1: Looks good to me, approved I had kept it this way, so that it is easy to understand that the second argument to mVerbs.put() is supposed to be the "display name". Currently, it happens to be exactly same as the field name, but could be different in future :) However, I don't have too strong a feeling about retaining this, so will accept it. -- To view, visit http://gerrit.ovirt.org/14405 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28129e1549232ba33db8b91ed9c5bd8061ad24f2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
