Liron Ar has posted comments on this change.

Change subject: core: avoid logging in ERROR on cancelled event.
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 1623: 
Line 1624:         if (masterDomain != null) {
Line 1625:             final Guid masterDomainId = masterDomain.getId();
Line 1626:             ((EventQueue) 
EjbUtils.findBean(BeanType.EVENTQUEUE_MANAGER, 
BeanProxyType.LOCAL)).submitEventAsync(new 
Event(getParameters().getStoragePoolId(),
Line 1627:                     masterDomainId, null, EventType.RECONSTRUCT, 
"IrsBrokerCommand.startReconstruct()"),
"Reconstruct caused by failure to execute spm command" - agreed?
Line 1628:                     new Callable<EventResult>() {
Line 1629:                         @Override
Line 1630:                         public EventResult call() {
Line 1631:                             return ResourceManager.getInstance()


--
To view, visit http://gerrit.ovirt.org/13311
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If192b3ccc5f5310de4fd80ca7fb4a7d74d52e1df
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to