Tal Nisan has uploaded a new change for review. Change subject: findbugs: Fix field should be package protected warning in uicommonweb project ......................................................................
findbugs: Fix field should be package protected warning in uicommonweb project Change-Id: I54b79981eb3732232f351f67809a6c622fdc1da2 Signed-off-by: Tal Nisan <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterPolicyModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java 2 files changed, 5 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/77/14477/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterPolicyModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterPolicyModel.java index a4cecb3..9f39357 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterPolicyModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterPolicyModel.java @@ -14,9 +14,9 @@ @SuppressWarnings("unused") public class ClusterPolicyModel extends EntityModel { - public static Integer lowLimitPowerSaving = null; - public static Integer highLimitPowerSaving = null; - public static Integer highLimitEvenlyDistributed = null; + static Integer lowLimitPowerSaving = null; + static Integer highLimitPowerSaving = null; + static Integer highLimitEvenlyDistributed = null; private EntityModel privateOverCommitTime; private boolean editClusterPolicyFirst; diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java index e942578..abd97c2 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java @@ -37,7 +37,8 @@ @SuppressWarnings("unused") public abstract class VmInterfaceModel extends Model { - public static String ENGINE_NETWORK_NAME; + public final static String ENGINE_NETWORK_NAME = + (String) AsyncDataProvider.GetConfigValuePreConverted(ConfigurationValues.ManagementNetwork); private boolean privateIsNew; private EntityModel privateName; @@ -68,10 +69,6 @@ ArrayList<VmNetworkInterface> vmNicList, EntityModel sourceModel) { - // get management network name - ENGINE_NETWORK_NAME = - (String) AsyncDataProvider.GetConfigValuePreConverted(ConfigurationValues.ManagementNetwork); - this.vm = vm; this.vmNicList = vmNicList; this.sourceModel = sourceModel; -- To view, visit http://gerrit.ovirt.org/14477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I54b79981eb3732232f351f67809a6c622fdc1da2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
