Tal Nisan has posted comments on this change.
Change subject: findbugs: Fix field should be package protected warning in
uicommonweb project
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterPolicyModel.java
Line 13:
Line 14: @SuppressWarnings("unused")
Line 15: public class ClusterPolicyModel extends EntityModel {
Line 16:
Line 17: static Integer lowLimitPowerSaving = null;
Compilation works fine so nothing except the package is using it, basically the
best way to work is to limit access as possible unless needed otherwise,
findbugs is mostly concerned I guess with the ability of classes from other
packages changing the references thus creating vulnerability in the code
Line 18: static Integer highLimitPowerSaving = null;
Line 19: static Integer highLimitEvenlyDistributed = null;
Line 20:
Line 21: private EntityModel privateOverCommitTime;
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java
Line 37: @SuppressWarnings("unused")
Line 38: public abstract class VmInterfaceModel extends Model
Line 39: {
Line 40: public final static String ENGINE_NETWORK_NAME =
Line 41: (String)
AsyncDataProvider.GetConfigValuePreConverted(ConfigurationValues.ManagementNetwork);
Same here, vulnerability, in any way this is to be treated a constant
Line 42:
Line 43: private boolean privateIsNew;
Line 44: private EntityModel privateName;
Line 45: private ListModel privateNetwork;
--
To view, visit http://gerrit.ovirt.org/14477
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54b79981eb3732232f351f67809a6c622fdc1da2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
