Alissa Bonas has posted comments on this change.
Change subject: frontend: Remove IteratorUtils class
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
Line 926: return getListName();
Line 927: }
Line 928:
Line 929: @SuppressWarnings("rawtypes")
Line 930: private static boolean moveNext(Iterator iterator) {
Why do we need this method? can't it be done inline above in the code that uses
it?
it's standard iterator methods... and what is the reason for making this method
static?
Line 931: if (iterator.hasNext()) {
Line 932: iterator.next();
Line 933: return true;
Line 934: }
--
To view, visit http://gerrit.ovirt.org/14487
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3d3669cd7d5ee0d127ca66ae3fff6b36986d601
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
