Allon Mureinik has posted comments on this change.
Change subject: frontend: Remove IteratorUtils class
......................................................................
Patch Set 1: (1 inline comment)
I think the real issue is that getItems and setItems use the Iterable interface
instead of a collection, for no good reason.
If these methods were amended, we could just use size() and isEmpty(), and save
all this trouble.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
Line 634:
Line 635: protected boolean getNextSearchPageAllowed()
Line 636: {
Line 637: if (!getSearchNextPageCommand().getIsAvailable() ||
getItems() == null
Line 638: || moveNext(getItems().iterator()) == false)
this should just be getItems().iterator().hasNext()
Line 639: {
Line 640: return false;
Line 641: }
Line 642:
--
To view, visit http://gerrit.ovirt.org/14487
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3d3669cd7d5ee0d127ca66ae3fff6b36986d601
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
