Tal Nisan has posted comments on this change.
Change subject: findbugs: Fix field is not final warnings in uicommonweb project
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
Line 55: {
Line 56:
Line 57: // get management network name from configuration
Line 58: public final static String ENGINE_NETWORK_NAME =
Line 59: (String)
AsyncDataProvider.GetConfigValuePreConverted(ConfigurationValues.ManagementNetwork);
How come? The behavior will be the same, it will be initialized before the
constructor, it's a constant anyway..
Line 60:
Line 61: private UICommand privateEditCommand;
Line 62:
Line 63: @Override
--
To view, visit http://gerrit.ovirt.org/14476
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10d4143c5b2adb031e56e0cc9ac2555e3605f177
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
