Allon Mureinik has posted comments on this change.
Change subject: findbugs: Fix field is not final warnings in uicommonweb project
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(13 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java
Line 111: }
Line 112:
Line 113: static
Line 114: {
Line 115: NavigatedEventDefinition = new EventDefinition("Navigated",
BookmarkListModel.class); //$NON-NLS-1$
I'd inline this to the field's definition while you're at it.
Line 116: }
Line 117:
Line 118: public BookmarkListModel()
Line 119: {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/ChangeCDModel.java
Line 37: privateDoCommand = value;
Line 38: }
Line 39:
Line 40: static
Line 41: {
I'd inline this to the field's definition while you're at it.
Line 42: ExecutedEventDefinition = new EventDefinition("Executed",
ChangeCDModel.class); //$NON-NLS-1$
Line 43: }
Line 44:
Line 45: public ChangeCDModel()
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AsyncIteratorCallback.java
Line 34: private void setAsyncQuery(AsyncQuery value) {
Line 35: asyncQuery = value;
Line 36: }
Line 37:
Line 38: static {
I'd inline this to the field's definition while you're at it.
Line 39: NotifyEventDefinition = new EventDefinition("Notify",
AsyncIteratorCallback.class); //$NON-NLS-1$
Line 40: }
Line 41:
Line 42: public AsyncIteratorCallback(String frontendContext) {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
Line 777: }
Line 778:
Line 779: static
Line 780: {
Line 781: RequestEditEventDefinition = new
EventDefinition("RequestEditEvent", HostGeneralModel.class); //$NON-NLS-1$
I'd inline these to the field's definition while you're at it.
Line 782: RequestGOToEventsTabEventDefinition = new
EventDefinition("RequestGOToEventsTabEvent", HostGeneralModel.class);
//$NON-NLS-1$
Line 783: }
Line 784:
Line 785: public HostGeneralModel()
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
Line 55: {
Line 56:
Line 57: // get management network name from configuration
Line 58: public final static String ENGINE_NETWORK_NAME =
Line 59: (String)
AsyncDataProvider.GetConfigValuePreConverted(ConfigurationValues.ManagementNetwork);
Can this value change while the engine is up?
Line 60:
Line 61: private UICommand privateEditCommand;
Line 62:
Line 63: @Override
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java
Line 398: }
Line 399: }
Line 400:
Line 401: static
Line 402: {
I'd inline this to the field's definition while you're at it.
Line 403: UpdateCompleteEventDefinition = new
EventDefinition("UpdateComplete", PoolGeneralModel.class); //$NON-NLS-1$
Line 404: }
Line 405:
Line 406: public PoolGeneralModel()
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java
Line 158: }
Line 159: }
Line 160:
Line 161: static
Line 162: {
I'd inline this to the field's definition while you're at it.
Line 163: ResetRequestedEventDefinition = new
EventDefinition("ResetRequested", SystemTreeModel.class); //$NON-NLS-1$
Line 164: }
Line 165:
Line 166: public TagListModel()
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagModel.java
Line 165: }
Line 166: }
Line 167:
Line 168: static
Line 169: {
I'd inline this to the field's definition while you're at it.
Line 170: SelectionChangedEventDefinition = new
EventDefinition("SelectionChanged", TagModel.class); //$NON-NLS-1$
Line 171: }
Line 172:
Line 173: public TagModel()
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java
Line 106:
Line 107: private final HashMap<Guid, ArrayList<ConsoleModel>>
cachedConsoleModels;
Line 108:
Line 109: static
Line 110: {
I'd inline this to the field's definition while you're at it.
Line 111: SearchCompletedEventDefinition = new
EventDefinition("SearchCompleted", UserPortalBasicListModel.class);
//$NON-NLS-1$
Line 112: }
Line 113:
Line 114: public UserPortalBasicListModel()
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
Line 263: CustomPropertiesKeysList = customPropertiesKeysList;
Line 264: }
Line 265:
Line 266: static
Line 267: {
I'd inline this to the field's definition while you're at it.
Line 268: SearchCompletedEventDefinition = new
EventDefinition("SearchCompleted", UserPortalListModel.class); //$NON-NLS-1$
Line 269: }
Line 270:
Line 271: public UserPortalListModel()
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java
Line 134: this.parentModel = parentModel;
Line 135: }
Line 136:
Line 137: static
Line 138: {
I'd inline this to the field's definition while you're at it.
Line 139: ErrorEventDefinition = new EventDefinition("Error",
ConsoleModel.class); //$NON-NLS-1$
Line 140: }
Line 141:
Line 142: protected ConsoleModel()
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java
Line 551: }
Line 552: }
Line 553:
Line 554: static
Line 555: {
I'd inline this to the field's definition while you're at it.
Line 556: UpdateCompleteEventDefinition = new
EventDefinition("UpdateComplete", VmGeneralModel.class); //$NON-NLS-1$
Line 557: }
Line 558:
Line 559: public VmGeneralModel()
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ProvideTickEvent.java
Line 8: public final static EventDefinition Definition;
Line 9:
Line 10: static
Line 11: {
Line 12: Definition = new EventDefinition("Tick",
IProvideTickEvent.class); //$NON-NLS-1$
I'd inline this to the field's definition while you're at it.
Line 13: }
--
To view, visit http://gerrit.ovirt.org/14476
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10d4143c5b2adb031e56e0cc9ac2555e3605f177
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
