Yair Zaslavsky has posted comments on this change. Change subject: core: reduce compensation scope from hibernate command ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java Line 150: getReturnValue().getTaskIdList().add(guid1); Line 151: getCompensationContext().resetCompensation(); Line 152: return null; Line 153: } Line 154: }); What happens if an error occurs after the task is created (let's say - at the createImage?) Line 155: Line 156: // second vol should be 10kb Line 157: Guid image2GroupId = Guid.NewGuid(); Line 158: -- To view, visit http://gerrit.ovirt.org/14510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec46798fc6ea01ef6b0b4701e1af5ba616edf910 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
