Liron Ar has posted comments on this change. Change subject: core: reduce compensation scope from hibernate command ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java Line 145: Guid guid1 = Line 146: createTask(ret1.getCreationInfo(), Line 147: VdcActionType.HibernateVm, Line 148: VdcObjectType.Storage, Line 149: getStorageDomainId().getValue()); IIRC - this seems to happen always out of the transaction, o it seems like there's no meaning to the new transaction here... regardless, in an edge case - the transaction might fail and the return list will still contain the guid functionally it won't matter with current code..but i think that it should be avoided as a practice. Line 150: getReturnValue().getTaskIdList().add(guid1); Line 151: getCompensationContext().resetCompensation(); Line 152: return null; Line 153: } -- To view, visit http://gerrit.ovirt.org/14510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec46798fc6ea01ef6b0b4701e1af5ba616edf910 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
