Gilad Chaplik has uploaded a new change for review. Change subject: uicompat: rename methods to begin with lowercase letter ......................................................................
uicompat: rename methods to begin with lowercase letter Although a method name can be any legal identifier, code conventions restrict method names. By convention, method names should be a verb in lowercase or a multi-word name that begins with a verb in lowercase. Note: Constants.java is skipped since it may affect localization process. Change-Id: Ib83c948510470072ab73b0aca1952024849e4fd7 Signed-off-by: Gilad Chaplik <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleNode.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddClusterRM.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddStorageDomainRM.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ChangeHostClusterRM.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Clipboard.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/DispatcherOperation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enlistment.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EventProvidingCollection.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ObservableCollection.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/PreparingEnlistment.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Task.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/TaskContext.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/TypeUtil.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UriValidator.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusCell.java 28 files changed, 96 insertions(+), 96 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/48/14648/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java index 12c4deb..8becfa8 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java @@ -95,7 +95,7 @@ { super.asyncSearch(); - Task.Create(this, null).InvokeUIThread(); + Task.create(this, null).invokeUIThread(); } @Override diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleNode.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleNode.java index 4f618f6..f32b364 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleNode.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleNode.java @@ -9,7 +9,7 @@ @SuppressWarnings("unused") public class RoleNode { - private static Translator actionGroupTranslator = EnumTranslator.Create(ActionGroup.class); + private static Translator actionGroupTranslator = EnumTranslator.create(ActionGroup.class); public RoleNode(String name, RoleNode[] leafs) { diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java index 6a88f94..632e9b9 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java @@ -753,7 +753,7 @@ getWindow().startProgress(null); - Task.Create(this, new ArrayList<Object>(Arrays.asList(new Object[] { "SaveLocal" }))).Run(); //$NON-NLS-1$ + Task.create(this, new ArrayList<Object>(Arrays.asList(new Object[] { "SaveLocal" }))).run(); //$NON-NLS-1$ } private void saveLocalStorage(TaskContext context) @@ -886,7 +886,7 @@ public void onFinish(TaskContext context, boolean isSucceeded, IStorageModel model, String message) { - context.InvokeUIThread(this, + context.invokeUIThread(this, new ArrayList<Object>(Arrays.asList(new Object[] { "Finish", isSucceeded, model, //$NON-NLS-1$ message }))); } @@ -900,7 +900,7 @@ getWindow().startProgress(null); - Task.Create(this, new ArrayList<Object>(Arrays.asList(new Object[] { "SaveNfs" }))).Run(); //$NON-NLS-1$ + Task.create(this, new ArrayList<Object>(Arrays.asList(new Object[] { "SaveNfs" }))).run(); //$NON-NLS-1$ } private void saveNfsStorage(TaskContext context) @@ -1039,7 +1039,7 @@ getWindow().startProgress(null); - Task.Create(this, new ArrayList<Object>(Arrays.asList(new Object[] { "SaveSan" }))).Run(); //$NON-NLS-1$ + Task.create(this, new ArrayList<Object>(Arrays.asList(new Object[] { "SaveSan" }))).run(); //$NON-NLS-1$ } private void saveSanStorage(TaskContext context) diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddClusterRM.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddClusterRM.java index 054ece5..d743642 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddClusterRM.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddClusterRM.java @@ -83,7 +83,7 @@ enlistmentContext.setClusterId(cluster.getId()); context.enlistment = null; - enlistment.Prepared(); + enlistment.prepared(); } else { Version version = (Version) clusterModel.getVersion().getSelectedItem(); @@ -118,7 +118,7 @@ enlistmentContext.setClusterId(configureModel.getCluster().getClusterId().getValue()); context.enlistment = null; - enlistment.Prepared(); + enlistment.prepared(); } } @@ -135,10 +135,10 @@ enlistmentContext.setClusterId((Guid) returnValue.getActionReturnValue()); context.enlistment = null; - enlistment.Prepared(); + enlistment.prepared(); } else { - enlistment.ForceRollback(); + enlistment.forceRollback(); } } @@ -195,12 +195,12 @@ @Override public void commit(Enlistment enlistment) { - enlistment.Done(); + enlistment.done(); } @Override public void rollback(Enlistment enlistment) { - enlistment.Done(); + enlistment.done(); } private final Context context = new Context(); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java index a5828e2..4044ae3 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java @@ -89,7 +89,7 @@ enlistmentContext.setDataCenterId(dataCenter.getId()); context.enlistment = null; - enlistment.Prepared(); + enlistment.prepared(); } else { dataCenter = new StoragePool(); @@ -116,7 +116,7 @@ enlistmentContext.setDataCenterId(configureModel.getDataCenter().getDataCenterId().getValue()); context.enlistment = null; - enlistment.Prepared(); + enlistment.prepared(); } } @@ -131,16 +131,16 @@ if (returnValue != null && returnValue.getSucceeded()) { enlistmentContext.setDataCenterId((Guid) returnValue.getActionReturnValue()); - enlistment.Prepared(); + enlistment.prepared(); } else { - enlistment.ForceRollback(); + enlistment.forceRollback(); } } @Override public void commit(Enlistment enlistment) { - enlistment.Done(); + enlistment.done(); } @Override @@ -217,7 +217,7 @@ if (abort) { context.enlistment = null; - enlistment.Done(); + enlistment.done(); return; } @@ -227,7 +227,7 @@ if (dataCenter.getstatus() != StoragePoolStatus.Uninitialized) { context.enlistment = null; - enlistment.Done(); + enlistment.done(); return; } @@ -249,7 +249,7 @@ } else { context.enlistment = null; - enlistment.Done(); + enlistment.done(); } } @@ -279,7 +279,7 @@ } } else { context.enlistment = null; - enlistment.Done(); + enlistment.done(); } } @@ -297,7 +297,7 @@ // Call done, no matter whether the data center deletion was successful. context.enlistment = null; - enlistment.Done(); + enlistment.done(); } // @Override diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddStorageDomainRM.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddStorageDomainRM.java index c4faeeb..44169d0 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddStorageDomainRM.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddStorageDomainRM.java @@ -73,7 +73,7 @@ if (returnValue == null || !returnValue.getSucceeded()) { context.enlistment = null; - enlistment.ForceRollback(); + enlistment.forceRollback(); } else { prepare3(); } @@ -111,7 +111,7 @@ } else { context.enlistment = null; - enlistment.ForceRollback(); + enlistment.forceRollback(); } } @@ -166,7 +166,7 @@ // Don't rollback. context.enlistment = null; - enlistment.Done(); + enlistment.done(); } else { StorageDomainStatic storage = new StorageDomainStatic(); @@ -229,20 +229,20 @@ // ReturnValue not equals null means remove connection occurred. if (returnValue != null) { // Don't rollback. - enlistment.Done(); + enlistment.done(); } else { - enlistment.Prepared(); + enlistment.prepared(); } } @Override public void commit(Enlistment enlistment) { - enlistment.Done(); + enlistment.done(); } @Override public void rollback(Enlistment enlistment) { - enlistment.Done(); + enlistment.done(); } private final Context context = new Context(); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ChangeHostClusterRM.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ChangeHostClusterRM.java index 0bd212f..2681cf8 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ChangeHostClusterRM.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ChangeHostClusterRM.java @@ -55,7 +55,7 @@ }); } else { context.enlistment = null; - enlistment.Prepared(); + enlistment.prepared(); } } @@ -68,9 +68,9 @@ if (returnValue != null && returnValue.getSucceeded()) { - enlistment.Prepared(); + enlistment.prepared(); } else { - enlistment.ForceRollback(); + enlistment.forceRollback(); } } @@ -96,12 +96,12 @@ @Override public void commit(Enlistment enlistment) { - enlistment.Done(); + enlistment.done(); } @Override public void rollback(Enlistment enlistment) { - enlistment.Done(); + enlistment.done(); } private final Context context = new Context(); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java index 240a049..420dd54 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java @@ -458,19 +458,19 @@ getvm().getCpuPerSocket())); poolGeneralModel.setMonitorCount(getvm().getNumOfMonitors()); - Translator translator = EnumTranslator.Create(VmOsType.class); + Translator translator = EnumTranslator.create(VmOsType.class); poolGeneralModel.setOS(translator.get(getvm().getVmOs())); poolGeneralModel.setDefinedMemory(getvm().getVmMemSizeMb() + " MB"); //$NON-NLS-1$ poolGeneralModel.setMinAllocatedMemory(getvm().getMinAllocatedMem() + " MB"); //$NON-NLS-1$ - translator = EnumTranslator.Create(DisplayType.class); + translator = EnumTranslator.create(DisplayType.class); poolGeneralModel.setDefaultDisplayType(translator.get(getvm().getDefaultDisplayType())); - translator = EnumTranslator.Create(OriginType.class); + translator = EnumTranslator.create(OriginType.class); poolGeneralModel.setOrigin(translator.get(getvm().getOrigin())); - translator = EnumTranslator.Create(UsbPolicy.class); + translator = EnumTranslator.create(UsbPolicy.class); poolGeneralModel.setUsbPolicy(translator.get(getvm().getUsbPolicy())); setHasDomain(AsyncDataProvider.isWindowsOsType(getvm().getVmOs())); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java index 13b2cb3..3e3f1e1 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java @@ -689,33 +689,33 @@ NfsStorageModel nfsModel = (NfsStorageModel) model.getSelectedItem(); nfsModel.setMessage(null); - Task.Create(this, + Task.create(this, new ArrayList<Object>(Arrays.asList(new Object[] { "ImportFile", //$NON-NLS-1$ - host.getId(), nfsModel.getPath().getEntity(), nfsModel.getRole(), StorageType.NFS }))).Run(); + host.getId(), nfsModel.getPath().getEntity(), nfsModel.getRole(), StorageType.NFS }))).run(); } else if (model.getSelectedItem() instanceof LocalStorageModel) { LocalStorageModel localModel = (LocalStorageModel) model.getSelectedItem(); localModel.setMessage(null); - Task.Create(this, + Task.create(this, new ArrayList<Object>(Arrays.asList(new Object[] { "ImportFile", //$NON-NLS-1$ - host.getId(), localModel.getPath().getEntity(), localModel.getRole(), StorageType.LOCALFS }))).Run(); + host.getId(), localModel.getPath().getEntity(), localModel.getRole(), StorageType.LOCALFS }))).run(); } else if (model.getSelectedItem() instanceof PosixStorageModel) { PosixStorageModel posixModel = (PosixStorageModel) model.getSelectedItem(); posixModel.setMessage(null); - Task.Create(this, + Task.create(this, new ArrayList<Object>(Arrays.asList(new Object[] { "ImportFile", //$NON-NLS-1$ - host.getId(), posixModel.getPath().getEntity(), posixModel.getRole(), StorageType.POSIXFS}))).Run(); + host.getId(), posixModel.getPath().getEntity(), posixModel.getRole(), StorageType.POSIXFS}))).run(); } else { - Task.Create(this, + Task.create(this, new ArrayList<Object>(Arrays.asList(new Object[] { "ImportSan", //$NON-NLS-1$ - host.getId() }))).Run(); + host.getId() }))).run(); } } @@ -965,7 +965,7 @@ getWindow().startProgress(null); - Task.Create(this, new ArrayList<Object>(Arrays.asList(new Object[] { "SaveLocal" }))).Run(); //$NON-NLS-1$ + Task.create(this, new ArrayList<Object>(Arrays.asList(new Object[] { "SaveLocal" }))).run(); //$NON-NLS-1$ } private void saveNfsStorage() @@ -977,7 +977,7 @@ getWindow().startProgress(null); - Task.Create(this, new ArrayList<Object>(Arrays.asList(new Object[] { "SaveNfs" }))).Run(); //$NON-NLS-1$ + Task.create(this, new ArrayList<Object>(Arrays.asList(new Object[] { "SaveNfs" }))).run(); //$NON-NLS-1$ } private void savePosixStorage() { @@ -988,7 +988,7 @@ getWindow().startProgress(null); - Task.Create(this, new ArrayList<Object>(Arrays.asList(new Object[] {"SavePosix"}))).Run(); //$NON-NLS-1$ + Task.create(this, new ArrayList<Object>(Arrays.asList(new Object[] {"SavePosix"}))).run(); //$NON-NLS-1$ } private void saveGlusterStorage() { @@ -999,7 +999,7 @@ getWindow().startProgress(null); - Task.Create(this, new ArrayList<Object>(Arrays.asList(new Object[] {"SaveGluster"}))).Run(); //$NON-NLS-1$ + Task.create(this, new ArrayList<Object>(Arrays.asList(new Object[] {"SaveGluster"}))).run(); //$NON-NLS-1$ } private void saveSanStorage() @@ -1028,7 +1028,7 @@ cancelConfirm(); getWindow().startProgress(null); - Task.Create(this, new ArrayList<Object>(Arrays.asList(new Object[] { "SaveSan" }))).Run(); //$NON-NLS-1$ + Task.create(this, new ArrayList<Object>(Arrays.asList(new Object[] { "SaveSan" }))).run(); //$NON-NLS-1$ } private void forceCreationWarning(ArrayList<String> usedLunsMessages) { @@ -1870,7 +1870,7 @@ public void onFinish(TaskContext context, boolean isSucceeded, IStorageModel model, String message) { - context.InvokeUIThread(this, + context.invokeUIThread(this, new ArrayList<Object>(Arrays.asList(new Object[] { "Finish", isSucceeded, model, //$NON-NLS-1$ message }))); } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateGeneralModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateGeneralModel.java index bc5ddd4..3f91a49 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateGeneralModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateGeneralModel.java @@ -460,13 +460,13 @@ template.getNumOfSockets(), template.getCpuPerSocket())); - Translator translator = EnumTranslator.Create(VmOsType.class); + Translator translator = EnumTranslator.create(VmOsType.class); setOS(translator.get(template.getOs())); - translator = EnumTranslator.Create(DisplayType.class); + translator = EnumTranslator.create(DisplayType.class); setDefaultDisplayType(translator.get(template.getDefaultDisplayType())); - translator = EnumTranslator.Create(OriginType.class); + translator = EnumTranslator.create(OriginType.class); setOrigin(translator.get(template.getOrigin())); setHasDomain(AsyncDataProvider.isWindowsOsType(template.getOs())); @@ -476,7 +476,7 @@ setTimeZone(template.getTimeZone()); setHasUsbPolicy(true); - translator = EnumTranslator.Create(UsbPolicy.class); + translator = EnumTranslator.create(UsbPolicy.class); setUsbPolicy(translator.get(template.getUsbPolicy())); setIsStateless(template.isStateless()); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java index 1b97ee1..abd8b3a 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java @@ -115,8 +115,8 @@ Map<EventNotificationEntity, HashSet<AuditLogType>> availableEvents = AsyncDataProvider.getAvailableNotificationEvents(); - Translator eventNotificationEntityTranslator = EnumTranslator.Create(EventNotificationEntity.class); - Translator auditLogTypeTranslator = EnumTranslator.Create(AuditLogType.class); + Translator eventNotificationEntityTranslator = EnumTranslator.create(EventNotificationEntity.class); + Translator auditLogTypeTranslator = EnumTranslator.create(AuditLogType.class); ArrayList<SelectionTreeNodeModel> list = new ArrayList<SelectionTreeNodeModel>(); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java index 384e543..f827003 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java @@ -107,7 +107,7 @@ { if (getSelectedItemIndex() < getItems().size() - 1) { - getItems().Move(getSelectedItemIndex(), getSelectedItemIndex() + 1); + getItems().move(getSelectedItemIndex(), getSelectedItemIndex() + 1); } } @@ -115,7 +115,7 @@ { if (getSelectedItemIndex() > 0) { - getItems().Move(getSelectedItemIndex(), getSelectedItemIndex() - 1); + getItems().move(getSelectedItemIndex(), getSelectedItemIndex() - 1); } } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java index 78e537d..965887d 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java @@ -596,13 +596,13 @@ setDefinedMemory(vm.getVmMemSizeMb() + " MB"); //$NON-NLS-1$ setMinAllocatedMemory(vm.getMinAllocatedMem() + " MB"); //$NON-NLS-1$ - Translator translator = EnumTranslator.Create(VmOsType.class); + Translator translator = EnumTranslator.create(VmOsType.class); setOS(translator.get(vm.getVmOs())); - translator = EnumTranslator.Create(DisplayType.class); + translator = EnumTranslator.create(DisplayType.class); setDefaultDisplayType(translator.get(vm.getDefaultDisplayType())); - translator = EnumTranslator.Create(OriginType.class); + translator = EnumTranslator.create(OriginType.class); setOrigin(translator.get(vm.getOrigin())); setHasHighlyAvailable(vm.getVmType() == VmType.Server); @@ -615,7 +615,7 @@ setMonitorCount(vm.getNumOfMonitors()); setHasUsbPolicy(true); - translator = EnumTranslator.Create(UsbPolicy.class); + translator = EnumTranslator.create(UsbPolicy.class); setUsbPolicy(translator.get(vm.getUsbPolicy())); setCpuInfo(ConstantsManager.getInstance().getMessages().cpuInfoLabel( @@ -638,7 +638,7 @@ setHasAlert(vm.getVmPauseStatus() != VmPauseStatus.NONE && vm.getVmPauseStatus() != VmPauseStatus.NOERR); if (getHasAlert()) { - translator = EnumTranslator.Create(VmPauseStatus.class); + translator = EnumTranslator.create(VmPauseStatus.class); setAlert(translator.get(vm.getVmPauseStatus())); } else diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Clipboard.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Clipboard.java index 7e3dd2a..f8afec6 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Clipboard.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Clipboard.java @@ -2,7 +2,7 @@ public class Clipboard { - public static void SetDataObject(String data) { + public static void setDataObject(String data) { // TODO Auto-generated method stub } diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/DispatcherOperation.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/DispatcherOperation.java index 637e10c..3db8953 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/DispatcherOperation.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/DispatcherOperation.java @@ -6,7 +6,7 @@ public DispatcherOperationStatus Status; - public void Abort() { + public void abort() { // TODO Auto-generated method stub } diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enlistment.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enlistment.java index 798aff9..8803544 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enlistment.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enlistment.java @@ -27,7 +27,7 @@ this.context = context; } - public void Done() { + public void done() { getDoneEvent().raise(this, EventArgs.Empty); } } diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java index 628588e..272d73f 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java @@ -20,7 +20,7 @@ this.type = type; } - public static <T> Translator Create(T type) { + public static <T> Translator create(T type) { EnumTranslator translator = translatorsMap.get(type); if (translator == null) { translator = new EnumTranslator(type); @@ -34,7 +34,7 @@ String title = constants.notAvailableLabel(); if (enumObj != null) { - Translator translator = EnumTranslator.Create(enumObj.getDeclaringClass()); + Translator translator = EnumTranslator.create(enumObj.getDeclaringClass()); title = enumObj.name(); try { diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EventProvidingCollection.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EventProvidingCollection.java index f5dd868..e91b7e8 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EventProvidingCollection.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EventProvidingCollection.java @@ -19,9 +19,9 @@ } @Override - protected void OnCollectionChanged(NotifyCollectionChangedEventArgs e) + protected void onCollectionChanged(NotifyCollectionChangedEventArgs e) { - super.OnCollectionChanged(e); + super.onCollectionChanged(e); getCollectionChangedEvent().raise(this, e); } } diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ObservableCollection.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ObservableCollection.java index 448c3f0..ae5908b 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ObservableCollection.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ObservableCollection.java @@ -16,7 +16,7 @@ * @param sourceIndex * @param destIndex */ - public void Move(int sourceIndex, int destIndex) { + public void move(int sourceIndex, int destIndex) { if (sourceIndex == destIndex || sourceIndex > this.size() || destIndex > this.size()) { return; } @@ -26,11 +26,11 @@ this.add(destIndex, tempObj); } - protected void OnCollectionChanged() { - OnCollectionChanged(new NotifyCollectionChangedEventArgs()); + protected void onCollectionChanged() { + onCollectionChanged(new NotifyCollectionChangedEventArgs()); } - protected void OnCollectionChanged(NotifyCollectionChangedEventArgs e) { + protected void onCollectionChanged(NotifyCollectionChangedEventArgs e) { collectionChangedEvent.raise(this, e); } @@ -47,45 +47,45 @@ @Override public boolean add(T e) { boolean b = super.add(e); - OnCollectionChanged(); + onCollectionChanged(); return b; } @Override public void add(int index, T element) { super.add(index, element); - OnCollectionChanged(); + onCollectionChanged(); } @Override public T set(int index, T element) { T t = super.set(index, element); - OnCollectionChanged(); + onCollectionChanged(); return t; } @Override public boolean remove(Object o) { boolean b = super.remove(o); - OnCollectionChanged(); + onCollectionChanged(); return b; } public void clear() { super.clear(); - OnCollectionChanged(); + onCollectionChanged(); } public boolean addAll(Collection<? extends T> c) { boolean b = super.addAll(c); - OnCollectionChanged(); + onCollectionChanged(); return b; } public boolean addAll(int index, Collection<? extends T> c) { boolean b = super.addAll(index, c); - OnCollectionChanged(); + onCollectionChanged(); return b; } diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/PreparingEnlistment.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/PreparingEnlistment.java index 61038c4..584ef3a 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/PreparingEnlistment.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/PreparingEnlistment.java @@ -31,11 +31,11 @@ rollbackEvent = new Event(RollbackEventDefinition); } - public void Prepared() { + public void prepared() { getPreparedEvent().raise(this, EventArgs.Empty); } - public void ForceRollback() { + public void forceRollback() { getRollbackEvent().raise(this, EventArgs.Empty); } } diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Task.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Task.java index e460016..38be729 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Task.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Task.java @@ -1,7 +1,7 @@ package org.ovirt.engine.ui.uicompat; public class Task { - public static Task Create(ITaskTarget target, Object state) + public static Task create(ITaskTarget target, Object state) { return new Task(target, state); } @@ -16,13 +16,13 @@ context = new TaskContext(Dispatcher.CurrentDispatcher, state); } - public void Run() + public void run() { target.run(context); } - public void InvokeUIThread() { + public void invokeUIThread() { //Java implementation to this method is identical to Run. - Run(); + run(); } } diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/TaskContext.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/TaskContext.java index 97af722..21effba 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/TaskContext.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/TaskContext.java @@ -19,7 +19,7 @@ setState(state); } - public void InvokeUIThread(ITaskTarget target, Object state) + public void invokeUIThread(ITaskTarget target, Object state) { setState(state); target.run(this); diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/TypeUtil.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/TypeUtil.java index 1a4213f..58606a2 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/TypeUtil.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/TypeUtil.java @@ -4,7 +4,7 @@ public final class TypeUtil { - public static <T> boolean IsListOf(Object obj) { + public static <T> boolean isListOf(Object obj) { throw new NotImplementedException(); } } diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UriValidator.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UriValidator.java index 5787a00..5b462cf 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UriValidator.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UriValidator.java @@ -1,7 +1,7 @@ package org.ovirt.engine.ui.uicompat; public class UriValidator { - public static boolean IsValid(String uri) { + public static boolean isValid(String uri) { // TODO: Implement URL validation via regexp or find a GWT supported method if there is one // throw new RuntimeException("org.ovirt.engine.ui.uicompat.UriValidator is not supported!"); return true; diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralPresenter.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralPresenter.java index 03b5469..4122a65 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralPresenter.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralPresenter.java @@ -140,7 +140,7 @@ addTextAndLinkAlert(view, messages.hostHasNoPowerManagementAlert(), model.getEditHostCommand()); } if (model.getNonOperationalReasonEntity() != null) { - Translator translator = EnumTranslator.Create(NonOperationalReason.class); + Translator translator = EnumTranslator.create(NonOperationalReason.class); addTextAlert(view, translator.get(model.getNonOperationalReasonEntity())); } } diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java index e88d353..a79c3e8 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java @@ -29,7 +29,7 @@ ViewIdHandler idHandler = GWT.create(ViewIdHandler.class); } - Translator transportTypeTranslator = EnumTranslator.Create(TransportType.class); + Translator transportTypeTranslator = EnumTranslator.create(TransportType.class); @Inject public MainTabVolumeView(MainModelProvider<GlusterVolumeEntity, VolumeListModel> modelProvider, ApplicationConstants constants) { diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java index 608141b..e7c4adf 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java @@ -118,7 +118,7 @@ } private void translateVolumeType(GlusterVolumeEntity volumeEntity) { - Translator translator = EnumTranslator.Create(GlusterVolumeType.class); + Translator translator = EnumTranslator.create(GlusterVolumeType.class); if (translator.containsKey(volumeEntity.getVolumeType())) { getDetailModel().setVolumeTypeSilently(translator.get(volumeEntity.getVolumeType())); diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusCell.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusCell.java index 685b78e..ad8a262 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusCell.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusCell.java @@ -89,7 +89,7 @@ String html = imagePrototype.getHTML(); // Append tooltip - Translator translator = EnumTranslator.Create(VmPauseStatus.class); + Translator translator = EnumTranslator.create(VmPauseStatus.class); String toolTip = translator.get(vm.getVmPauseStatus()); html = html.replaceFirst("img", "img " + "title='" + toolTip + "' "); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ -- To view, visit http://gerrit.ovirt.org/14648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib83c948510470072ab73b0aca1952024849e4fd7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
