Michael Pasternak has posted comments on this change.
Change subject: restapi: Support View and Reload of System Configuration
......................................................................
Patch Set 5: (9 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateConfigurationValueCommand.java
Line 11: import org.ovirt.engine.core.common.config.Config;
Line 12: import org.ovirt.engine.core.dal.VdcBllMessages;
Line 13:
Line 14: @LockIdNameAttribute
Line 15: public class UpdateConfigurationValueCommand<T extends
UpdateConfigurationValueParameters> extends CommandBase<T> {
we yet not supporting update in api, adding this command to backend has no value
Line 16:
Line 17: private static final String GENERAL = "general";
Line 18:
Line 19: public UpdateConfigurationValueCommand(T parameters) {
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ConfigurationItemResource.java
Line 4:
Line 5: import org.ovirt.engine.api.model.ConfigurationItem;
Line 6:
Line 7: @Produces({ MediaType.APPLICATION_XML, MediaType.APPLICATION_JSON,
MediaType.APPLICATION_X_YAML })
Line 8: public interface ConfigurationItemResource extends
UpdatableResource<ConfigurationItem> {
should not be updatable in this stage
Line 9:
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ConfigurationItemsResource.java
Line 28: @Formatted
Line 29: @Consumes({ MediaType.APPLICATION_XML, MediaType.APPLICATION_JSON,
MediaType.APPLICATION_X_YAML })
Line 30: @Actionable
Line 31: @Path("reload")
Line 32: public Response reload(Action action);
should not be supported in this stage
Line 33:
Line 34: @Path("{id}")
Line 35: public ConfigurationItemResource
getConfigurationItemResource(@PathParam("id") String id);
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 498: <xs:appinfo>
Line 499: <jaxb:property generateIsSetMethod="false"/>
Line 500: </xs:appinfo>
Line 501: </xs:annotation>
Line 502: </xs:attribute>
TABs
Line 503: </xs:extension>
Line 504: </xs:complexContent>
Line 505: </xs:complexType>
Line 506:
Line 3136: </xs:sequence>
Line 3137: </xs:extension>
Line 3138: </xs:complexContent>
Line 3139: </xs:complexType>
Line 3140:
WS
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendConfigurationItemResource.java
Line 30: return notFound();
Line 31: }
Line 32:
Line 33: @Override
Line 34: public ConfigurationItem update(ConfigurationItem updatedItem) {
should not be supported in this stage
Line 35: validateParameters(updatedItem, "value");
Line 36: ConfigurationItem item = get();
Line 37: if (updatedItem.isSetValue()) {
Line 38: item.setValue(updatedItem.getValue());
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendConfigurationItemsResource.java
Line 70:
Line 71: @Override
Line 72: protected Response performRemove(String id) {
Line 73: // Remove will never be called. Also this stub will soon not
be necessary.
Line 74: return null;
in other classes we throw UnsupportedOperation
Line 75: }
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java
Line 166: BASE_PATH + "/vms",
Line 167: BASE_PATH + "/vms?search={query}",
Line 168: BASE_PATH + "/disks",
Line 169: BASE_PATH + "/disks?search={query}",
Line 170: BASE_PATH + "/configuration",
alignment
Line 171: };
Line 172:
Line 173: private static final String[] hrefsGlusterOnly = {
Line 174: BASE_PATH + "/capabilities",
....................................................
Commit Message
Line 3: AuthorDate: 2013-01-28 12:18:12 +0200
Line 4: Commit: Ori Liel <[email protected]>
Line 5: CommitDate: 2013-05-13 15:26:53 +0300
Line 6:
Line 7: restapi: Support View and Reload of System Configuration
only view, this feature should be exposed in read-only mode.
Line 8:
Line 9: Change-Id: I3d5cf3a09cfbf4bfb7586ba296e13f71386c396f
--
To view, visit http://gerrit.ovirt.org/11468
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d5cf3a09cfbf4bfb7586ba296e13f71386c396f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
