Shahar Havivi has uploaded a new change for review. Change subject: findbugs: ignore: Method might ignore exception ......................................................................
findbugs: ignore: Method might ignore exception Change-Id: Id1b56c036f2899d8ac53b7dd8e863e16e63429ae Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/utils/exclude-filters.xml M backend/manager/modules/utils/pom.xml A backend/manager/tools/exclude-filters.xml M backend/manager/tools/pom.xml 4 files changed, 36 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/13/14713/1 diff --git a/backend/manager/modules/utils/exclude-filters.xml b/backend/manager/modules/utils/exclude-filters.xml index c9ece2e..74d27a6 100644 --- a/backend/manager/modules/utils/exclude-filters.xml +++ b/backend/manager/modules/utils/exclude-filters.xml @@ -4,4 +4,10 @@ <Method name="getInstance"/> <Bug code="DC"/> </Match> + + <Match> + <Class name="org.ovirt.engine.core.utils.ssh.TransferTest" /> + <Method name="tearDown"/> + <Bug code="DE"/> + </Match> </FindBugsFilter> diff --git a/backend/manager/modules/utils/pom.xml b/backend/manager/modules/utils/pom.xml index 825d79d..69b355e 100644 --- a/backend/manager/modules/utils/pom.xml +++ b/backend/manager/modules/utils/pom.xml @@ -172,17 +172,6 @@ <groupId>org.ovirt.engine</groupId> <artifactId>jboss-modules-maven-plugin</artifactId> </plugin> - <plugin> - <groupId>org.codehaus.mojo</groupId> - <artifactId>findbugs-maven-plugin</artifactId> - <version>${findbugs.version}</version> - <configuration> - <xmlOutput>true</xmlOutput> - <!-- Optional directory to put findbugs xdoc xml report --> - <excludeFilterFile>exclude-filters.xml</excludeFilterFile> - <xmlOutputDirectory>target/site</xmlOutputDirectory> - </configuration> - </plugin> </plugins> </build> @@ -194,4 +183,5 @@ </properties> </profile> </profiles> + </project> diff --git a/backend/manager/tools/exclude-filters.xml b/backend/manager/tools/exclude-filters.xml new file mode 100644 index 0000000..f0cd3ce --- /dev/null +++ b/backend/manager/tools/exclude-filters.xml @@ -0,0 +1,7 @@ +<FindBugsFilter> + <Match> + <Class name="org.ovirt.engine.core.config.entity.ConfigKey" /> + <Method name="toString"/> + <Bug code="DE"/> + </Match> +</FindBugsFilter> diff --git a/backend/manager/tools/pom.xml b/backend/manager/tools/pom.xml index d1f8697..e029485 100644 --- a/backend/manager/tools/pom.xml +++ b/backend/manager/tools/pom.xml @@ -86,6 +86,17 @@ <groupId>org.ovirt.engine</groupId> <artifactId>jboss-modules-maven-plugin</artifactId> </plugin> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>findbugs-maven-plugin</artifactId> + <version>${findbugs.version}</version> + <configuration> + <xmlOutput>true</xmlOutput> + <!-- Optional directory to put findbugs xdoc xml report --> + <excludeFilterFile>exclude-filters.xml</excludeFilterFile> + <xmlOutputDirectory>target/site</xmlOutputDirectory> + </configuration> + </plugin> </plugins> </build> @@ -100,6 +111,17 @@ <excludes/> </configuration> </plugin> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>findbugs-maven-plugin</artifactId> + <version>${findbugs.version}</version> + <configuration> + <xmlOutput>true</xmlOutput> + <!-- Optional directory to put findbugs xdoc xml report --> + <excludeFilterFile>exclude-filters.xml</excludeFilterFile> + <xmlOutputDirectory>target/site</xmlOutputDirectory> + </configuration> + </plugin> </plugins> </build> </profile> -- To view, visit http://gerrit.ovirt.org/14713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id1b56c036f2899d8ac53b7dd8e863e16e63429ae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
