Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: added FQDN validation to engine-setup-2
......................................................................
Patch Set 4: (7 inline comments)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/config/protocols.py
Line 83: _DIG_LOOKUP_RE = re.compile(
Line 84: flags=re.VERBOSE,
Line 85: pattern=r"""
Line 86: ^
Line 87: (?P<query>[^\t]+)
I don't think we should rely on tab explicitly...
[\w.]+
Line 88: \t
Line 89: \t
Line 90: \d+
Line 91: \t
Line 84: flags=re.VERBOSE,
Line 85: pattern=r"""
Line 86: ^
Line 87: (?P<query>[^\t]+)
Line 88: \t
\s+ ?
Line 89: \t
Line 90: \d+
Line 91: \t
Line 92: IN
Line 87: (?P<query>[^\t]+)
Line 88: \t
Line 89: \t
Line 90: \d+
Line 91: \t
\s+ ?
Line 92: IN
Line 93: \t
Line 94: A
Line 95: \t
Line 89: \t
Line 90: \d+
Line 91: \t
Line 92: IN
Line 93: \t
\s ?
Line 94: A
Line 95: \t
Line 96: (?P<answer>\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})
Line 97:
Line 90: \d+
Line 91: \t
Line 92: IN
Line 93: \t
Line 94: A
Only A?
dig www.microsoft.com
Line 95: \t
Line 96: (?P<answer>\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})
Line 97:
Line 98: """
Line 91: \t
Line 92: IN
Line 93: \t
Line 94: A
Line 95: \t
\s ?
Line 96: (?P<answer>\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})
Line 97:
Line 98: """
Line 99: )
Line 92: IN
Line 93: \t
Line 94: A
Line 95: \t
Line 96: (?P<answer>\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})
are we sure we need only IP? Why not just be happy with any answer?
Line 97:
Line 98: """
Line 99: )
Line 100:
--
To view, visit http://gerrit.ovirt.org/14699
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9764f32ba5e30062532bf11c67756677333c44f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
