Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: added FQDN validation to engine-setup-2
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/config/protocols.py
Line 90: \d+
Line 91: \t
Line 92: IN
Line 93: \t
Line 94: A
> I thought that all is required is to see host is defined in dns and have
> reverse lookup setup.
> I still don't quite understand the need to match the address.
Ok, and you can't reverse lookup a CNAME.
> But... let's say host is defined in dns, we validate this using dig... why
> not use socket.getaddrinfo() to resolve it to address?
ok for this, also if I prefer socket.gethostbyname_ex for that purpose. Also if
I think that resolving again the fqdn having already the lookup result seems
redundant.
However, socket.getaddrinfo() just returns address coming from A answer
section, totally ignoring CNAMES.
Line 95: \t
Line 96: (?P<answer>\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})
Line 97:
Line 98: """
--
To view, visit http://gerrit.ovirt.org/14699
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9764f32ba5e30062532bf11c67756677333c44f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
