Alon Bar-Lev has posted comments on this change. Change subject: packaging - fix otopi implementation version locking handling ......................................................................
Patch Set 3: (1 inline comment) .................................................... File packaging/setup/plugins/ovirt-engine-remove/distro-rpm/versionlock.py Line 71: ) as locking_list_file: Line 72: oldcontent = locking_list_file.read() Line 73: new_content = [] Line 74: for line in oldcontent.splitlines(): Line 75: if line.find(osetupcons.Const.ENGINE_PACKAGE_NAME) == -1: ovirt-engine-reports? ovirt-engine-iso-uploader? anyway, better to find prefix... as we agreed, there should be uninstall mechanism to clean up lines we add, something generic. Line 76: new_content.append(line) Line 77: Line 78: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 79: filetransaction.FileTransaction( -- To view, visit http://gerrit.ovirt.org/14700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1b9142088cfa7def37f6d1ad3d2a4204aebe8ae Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
