Arik Hadas has posted comments on this change.

Change subject: engine : Fail tasks that dont have Vdsm Id
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 330: 
Line 331:     private void clearAsyncTasksWithOutVdsmId() {
Line 332:         for (Guid asyncTaskId : 
getReturnValue().getAsyncTaskIdList()) {
Line 333:             AsyncTasks task = 
DbFacade.getInstance().getAsyncTaskDao().get(asyncTaskId);
Line 334:             if (task.getTaskId().equals(NGuid.Empty)) {
should be getVdsmTaskId?
Line 335:                 AsyncTaskManager.failTaskWithoutVdsmId(task);
Line 336:             }
Line 337:         }
Line 338:     }


--
To view, visit http://gerrit.ovirt.org/14368
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I110c483842027d1596f64dd8c3f635d62924a93f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to