Yair Zaslavsky has posted comments on this change.
Change subject: engine : Fail tasks that dont have Vdsm Id
......................................................................
Patch Set 7: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
Line 179: }
Line 180: return false;
Line 181: }
Line 182:
Line 183: public static void failTaskWithoutVdsmId(final AsyncTasks
task) {
WithoutdVsmTaskId
Line 184: task.getTaskParameters().setTaskGroupSuccess(false);
Line 185: ExecutionHandler.endTaskStep(task.getStepId(),
JobExecutionStatus.FAILED);
Line 186: removeTaskFromDbByTaskId(task.getTaskId());
Line 187: if (task.getTaskType() == AsyncTaskType.unknown) {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java
Line 55: Guid taskId =
this.createAsyncTask(VdcActionType.AddVmFromTemplate,
Line 56: VdcObjectType.Storage,
Line 57: getParameters().getStorageDomainId(),
Line 58: getDestinationStorageDomainId());
Line 59: getReturnValue().getAsyncTaskIdList().add(taskId);
Ravi, general question here - why does the add(taskId) part was not introduced
in the previous patch in the patchset?
Line 60:
Line 61: vdsReturnValue = Backend
Line 62: .getInstance()
Line 63: .getResourceManager()
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcReturnValueBase.java
Line 16: private boolean _succeeded;
Line 17: private boolean _isSyncronious;
Line 18: private Object _returnValue;
Line 19: private String _description = "";
Line 20: private ArrayList<Guid> _asyncTaskIdList = new ArrayList<Guid>();
Kind confused here - care to explain difference bwtween _asyncTaskIdList and
_taskIdList?
Also, bad convention in field names is not an excuse to continue it :) use
field with no _.
Line 21: private ArrayList<Guid> _taskIdList = new ArrayList<Guid>();
Line 22: private final ArrayList<Guid> _internalIdList = new
ArrayList<Guid>();
Line 23: private boolean _endActionTryAgain = true;
Line 24: private final ArrayList<String> _executeFailedMessages = new
ArrayList<String>();
--
To view, visit http://gerrit.ovirt.org/14368
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I110c483842027d1596f64dd8c3f635d62924a93f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
