Mike Kolesnik has posted comments on this change. Change subject: engine: Added provider table & DAO ......................................................................
Patch Set 18: (3 inline comments) Fixed missing fields issues .................................................... File backend/manager/dbscripts/providers_sp.sql Line 18: INSERT INTO providers( Line 19: id, Line 20: name, Line 21: description, Line 22: url) Done Line 23: VALUES( Line 24: v_id, Line 25: v_name, Line 26: v_description, Line 87: SELECT * Line 88: FROM providers Line 89: WHERE id = v_id; Line 90: END; $procedure$ Line 91: LANGUAGE plpgsql; I tend to agree that it can be in a separate patch when it's needed. .................................................... File backend/manager/modules/dal/src/test/resources/fixtures.xml Line 672: <value>1115c1c6-cb15-4832-b2a4-023770607111</value> Line 673: <value>provider</value> Line 674: <value>External provider</value> Line 675: <value>http://provider.com</value> Line 676: </row> Done Line 677: </table> Line 678: Line 679: <table name="network"> Line 680: <column>id</column> -- To view, visit http://gerrit.ovirt.org/10785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa461cb6721b866c0a6f6531365c8af4d46eb1bb Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
