Yair Zaslavsky has posted comments on this change. Change subject: engine: Added provider table & DAO ......................................................................
Patch Set 22: Looks good to me, but someone else must approve Giving +1 - but I still think we should consider not decrypting auth_password, but doing that on demand. Regarding Mike's comment on - more complex design when this is needed, we can have some ProxyUtils that will provide a static method of decryptAuthPassword, or a base Proxy class that will contain a method for decryptying the password. Up to you, I think we should do this sooner than later. -- To view, visit http://gerrit.ovirt.org/10785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa461cb6721b866c0a6f6531365c8af4d46eb1bb Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
