Allon Mureinik has uploaded a new change for review. Change subject: core: Remove GetAllAdGroupsQuery ......................................................................
core: Remove GetAllAdGroupsQuery Removed GetAllAdGroupsQuery and its corresponding constant in VdcQueryType, as it is not used anywhere in the production code (only a rest-api test). Change-Id: Ie17c0765cb0b22f6472371794fd229c9c4ebd3d8 Signed-off-by: Allon Mureinik <[email protected]> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAdGroupsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceTest.java 3 files changed, 0 insertions(+), 23 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/06/14806/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAdGroupsQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAdGroupsQuery.java deleted file mode 100644 index 9250cd0..0000000 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAdGroupsQuery.java +++ /dev/null @@ -1,15 +0,0 @@ -package org.ovirt.engine.core.bll; - -import org.ovirt.engine.core.common.queries.*; -import org.ovirt.engine.core.dal.dbbroker.*; - -public class GetAllAdGroupsQuery<P extends VdcQueryParametersBase> extends QueriesCommandBase<P> { - public GetAllAdGroupsQuery(P parameters) { - super(parameters); - } - - @Override - protected void executeQueryCommand() { - getQueryReturnValue().setReturnValue(DbFacade.getInstance().getAdGroupDao().getAll()); - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java index 8897a3c..c0e2f06 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java @@ -93,7 +93,6 @@ GetUserBySessionId(VdcQueryAuthType.User), // AdGroups queries - GetAllAdGroups, GetAdGroupById, // VM pools queries diff --git a/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceTest.java b/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceTest.java index e5842d8..e6fae65 100644 --- a/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceTest.java +++ b/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceTest.java @@ -260,13 +260,6 @@ protected void setUpQueryExpectations(String query, Object failure) throws Exception { assert(query.equals("")); - setUpEntityQueryExpectations(VdcQueryType.GetAllAdGroups, - VdcQueryParametersBase.class, - new String[] { }, - new Object[] { }, - setUpGroups(), - failure); - control.replay(); } -- To view, visit http://gerrit.ovirt.org/14806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie17c0765cb0b22f6472371794fd229c9c4ebd3d8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
