Yair Zaslavsky has posted comments on this change.
Change subject: core: Changes type of VmDevice from String to enum
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDeviceGeneralType.java
Line 1: package org.ovirt.engine.core.common.businessentities;
Line 2:
Line 3: /**
Line 4: * General types of devices recognized by VDSM
Line 5: */
They are not overlapping. Blame libvirt for that (having DISK as VmDeviceType
for example).
Line 6: public enum VmDeviceGeneralType {
Line 7: /**
Line 8: * A hard disk, floppy or cdrom device
Line 9: */
Line 52: /**
Line 53: * Converts enum type to string value to save in database
Line 54: */
Line 55: public String getValue() {
Line 56: return name().toLowerCase();
Sure, I agree here.
Line 57: }
Line 58:
Line 59: /**
Line 60: * Converts string representation to enum value
--
To view, visit http://gerrit.ovirt.org/14812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icada39e3918fb053cb0ad0388178ccf5c6338ca2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
