Kanagaraj M has posted comments on this change.
Change subject: gluster: Corrected the event log message
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetGlusterVolumeOptionsCommand.java
Line 29: @Override
Line 30: public Map<String, String> getCustomValues() {
Line 31: if(getParameters().getVolumeOption() != null) {
Line 32: addCustomValue(GlusterConstants.OPTION_KEY,
getParameters().getVolumeOption().getKey());
Line 33: addCustomValue(GlusterConstants.OPTION_VALUE,
getParameters().getVolumeOption().getValue());
Value could be null when ResetGlusterVolumeOptions is called from the REST api.
You may not get the expected audit log in this case.
Please checkout this flow.
Line 34: }
Line 35: return super.getCustomValues();
Line 36: }
Line 37:
--
To view, visit http://gerrit.ovirt.org/14884
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd53a3f6a0ef671562a510275d6dd54417669545
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
