Sahina Bose has posted comments on this change.
Change subject: gluster: Corrected the event log message
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
Minor comment inline
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetGlusterVolumeOptionsCommand.java
Line 51: if (getSucceeded()) {
Line 52:
Line 53: if (getParameters().getVolumeOption() != null &&
!(getParameters().getVolumeOption().getKey().isEmpty())) {
Line 54: GlusterVolumeOptionEntity entity =
getGlusterVolume().getOption(getParameters().getVolumeOption().getKey());
Line 55:
removeOptionInDb(getGlusterVolume().getOption(getParameters().getVolumeOption().getKey()));
Minor- you could reuse entity here.
Line 56: isResetAllOptions = false;
Line 57:
getParameters().getVolumeOption().setValue((entity.getValue() != null) ?
entity.getValue() : "");
Line 58: } else {
Line 59: for (GlusterVolumeOptionEntity option :
getGlusterVolume().getOptions()) {
--
To view, visit http://gerrit.ovirt.org/14884
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd53a3f6a0ef671562a510275d6dd54417669545
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
