Yedidyah Bar David has posted comments on this change.

Change subject: packaging: log rotate
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File packaging/etc/logrotate.d/ovirt-engine.in
Line 1: "@ENGINE_LOG@/engine.log" "@ENGINE_LOG@/server.log" {
Line 2:         minsize 10M
Line 3:         size 100M
But you also want  debuggability - is 5 days enough?
I guess they compress very well.
Line 4:         missingok
Line 5:         copytruncate
Line 6:         rotate 5
Line 7:         compress


Line 12:        missingok
Line 13:        rotate 2
Line 14:        compress
Line 15:        postrotate
Line 16:                rm -f "$1"
I'd personally not rotate it at all, just leave it forever. It's not that we do 
not do this with other logs, such as /root/install.log .
Line 17:        endscript


--
To view, visit http://gerrit.ovirt.org/14961
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3570ae0e07a6884dcfc47bc49795f2ad17ab6c43
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to