Yedidyah Bar David has posted comments on this change.
Change subject: packaging: log rotate
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File packaging/etc/logrotate.d/ovirt-engine.in
Line 2: daily
Line 3: minsize 10M
Line 4: missingok
Line 5: copytruncate
Line 6: rotate 480
You probably meant 20 (with daily)
Line 7: compress
Line 8: }
Line 9:
Line 10: "@ENGINE_LOG@/host-deploy"/*.log {
Line 6: rotate 480
Line 7: compress
Line 8: }
Line 9:
Line 10: "@ENGINE_LOG@/host-deploy"/*.log {
As I said, I think we can leave them as-is, better compressed, not rotated or
deleted.
I do not see a problem with a few tens of such logs lying in their own
directory.
Line 11: monthly
Line 12: missingok
Line 13: rotate 2
Line 14: compress
--
To view, visit http://gerrit.ovirt.org/14961
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3570ae0e07a6884dcfc47bc49795f2ad17ab6c43
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
