Maor Lipchuk has posted comments on this change.
Change subject: tools: Trusted Compute Pools - Open Attestation integration
with oVirt engine proposal
......................................................................
Patch Set 1: (5 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
Line 1287: public void setTransparentHugePages(boolean value) {
Line 1288: this.transparentHugePages = value;
Line 1289: }
Line 1290:
Line 1291: private boolean trustedService;
Don't you want to add this field to the equlas/hashCode methods. It could
probably be a benefit in the testing process on this entity field. (If doing so
you will probably need to add it to fixtures.xml as well)
Line 1292:
Line 1293: public void setTrustedService(boolean trustedService) {
Line 1294: this.trustedService = trustedService;
Line 1295: }
Line 1293: public void setTrustedService(boolean trustedService) {
Line 1294: this.trustedService = trustedService;
Line 1295: }
Line 1296:
Line 1297: public boolean supportsTrustedService() {
Probably better to use the java convention method name, isTrustedService()
Line 1298: return trustedService;
Line 1299: }
Line 1300:
Line 1301: @Override
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
Line 31: private VmTemplateStatus status = VmTemplateStatus.OK;
Line 32:
Line 33: private String vdsGroupName;
Line 34:
Line 35: private boolean trustedService;
Don't you want to add this field to the equlas/hashCode methods. It could
probably be a benefit in the testing process on this entity field. (If doing so
you will probably need to add it to fixtures.xml as well)
Line 36:
Line 37: private NGuid storagePoolId;
Line 38:
Line 39: private String storagePoolName;
Line 131: public void setTrustedService(boolean trustedService) {
Line 132: this.trustedService = trustedService;
Line 133: }
Line 134:
Line 135: public boolean supportsTrustedService() {
Probably better to use the java convention method name, isTrustedService()
Line 136: return trustedService;
Line 137: }
Line 138:
Line 139: @Override
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
Line 165:
Line 166: node = content.SelectSingleNode("TrustedService");
Line 167: if (node != null) {
Line 168:
_vmTemplate.setTrustedService(Boolean.parseBoolean(node.InnerText));
Line 169: }
It looks like the new code is not formatted accurately (one space less then the
other code lines above), Are you working with the engine-code-format in your
IDE?
Line 170: }
Line 171:
Line 172: @Override
Line 173: protected String getDefaultDisplayTypeStringRepresentation() {
--
To view, visit http://gerrit.ovirt.org/14729
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f42f848798706be58acf1291c1841da1135d76d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dave Chen <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Emily Zhang <[email protected]>
Gerrit-Reviewer: Gang Wei <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
