Maor Lipchuk has posted comments on this change.
Change subject: tools: Trusted Compute Pools - Open Attestation integration
with oVirt engine proposal
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
Line 1287: public void setTransparentHugePages(boolean value) {
Line 1288: this.transparentHugePages = value;
Line 1289: }
Line 1290:
Line 1291: private boolean trustedService;
You can ignore this comment, after I saw that equlas in the Vm is quite simple,
it's not a must.
Line 1292:
Line 1293: public void setTrustedService(boolean trustedService) {
Line 1294: this.trustedService = trustedService;
Line 1295: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
Line 31: private VmTemplateStatus status = VmTemplateStatus.OK;
Line 32:
Line 33: private String vdsGroupName;
Line 34:
Line 35: private boolean trustedService;
You can ignore this comment, after I saw that equlas and hashcode in the
VmTemplate are quite simple, it's not a must
Line 36:
Line 37: private NGuid storagePoolId;
Line 38:
Line 39: private String storagePoolName;
--
To view, visit http://gerrit.ovirt.org/14729
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f42f848798706be58acf1291c1841da1135d76d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dave Chen <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Emily Zhang <[email protected]>
Gerrit-Reviewer: Gang Wei <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
