Martin Peřina has posted comments on this change.
Change subject: core: Adds custom properties to VmDevice
......................................................................
Patch Set 8: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetDeviceCustomPropertiesParameters.java
Line 16:
Line 17: /**
Line 18: * Device type to get custom properties for
Line 19: */
Line 20: private VmDeviceGeneralType deviceType;
This query is used to get map of allowed properties with their validation
pattern as a string. So for example if you have a device bridge
(VmDevice.device), you look at its type (VmDevice.type) and calling this query
you get all properties, that this device type can have.
Dan Kenigsberg in email from May 2nd wrote, that coarse grains device type here
are better for this case and he's ok with case that for example a cdrom device
can get same properties as disk. The same email I sent to engine-devel on May
3rd and no one have any objections against it.
So if your really want to differ custom properties per device (VmDevice.device)
and not device type (VmDevice.type), I can dump all VmDevice.type String to
enum patches and start from 0.
Line 21:
Line 22: public Version getVersion() {
Line 23: return version;
Line 24: }
--
To view, visit http://gerrit.ovirt.org/14814
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07daa5cccbf8e3cbd6b4191bbc8ebf0729d9d9a0
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
