Alona Kaplan has posted comments on this change.
Change subject: core: Adds custom properties to VmDevice
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/DevicePropertiesUtils.java
Line 253: * @param type
Line 254: * specified device type
Line 255: * @return map of device properties
Line 256: */
Line 257: public Map<String, Pattern> getDeviceProperties(Version version,
VmDeviceGeneralType type) {
Due to GWT limitations "Pattern" class can't be used in the client side.
In GetDeviceCustomPropertiesQuery can you please return a Map<String, String>
instead of Map<String, Pattern>?
Line 258: if (!FeatureSupported.deviceCustomProperties(version)) {
Line 259: return Collections.emptyMap();
Line 260: }
Line 261:
--
To view, visit http://gerrit.ovirt.org/14814
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07daa5cccbf8e3cbd6b4191bbc8ebf0729d9d9a0
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
