Alon Bar-Lev has posted comments on this change.

Change subject: packaging: setup: force Apache proxy on upgrade
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 202:         '--http-port',
Line 203:         help=output_messages.INFO_CONF_PARAMS_HTTP_PORT_USAGE,
Line 204:         action='store',
Line 205:         dest='http',
Line 206:         default='80'
how come it won't be 80?
Line 207:     )
Line 208: 
Line 209:     parser.add_option(
Line 210:         '--https-port',


Line 259: def checkHttpd(options):
Line 260:     handler = utils.TextConfigFileHandler(
Line 261:         basedefs.FILE_ENGINE_CONF_PROTOCOLS,
Line 262:         readExisting=True,
Line 263:     )
I am not sure we have this in legacy...
Line 264:     handler.open()
Line 265:     answer = False
Line 266:     haveConfig = False
Line 267:     proxyEnabled = handler.getParam('ENGINE_PROXY_ENABLED') == 'true'


--
To view, visit http://gerrit.ovirt.org/15051
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib46bcf40acff860cd3e52634ade683d7a8836cf6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to