Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: force Apache proxy on upgrade
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 259: def checkHttpd(options):
Line 260: handler = utils.TextConfigFileHandler(
Line 261: basedefs.FILE_ENGINE_CONF_PROTOCOLS,
Line 262: readExisting=True,
Line 263: )
this = FILE_ENGINE_CONF_PROTOCOLS or this = TextConfigFileHandler ?
TextConfigFileHandler is used in ./common_utils.py:1240 for writing
FILE_ENGINE_CONF_PROTOCOLS as part of editEngineSysconfigProtocols called by
legacy engine-setup.
Not sure it exists in 3.2.x, I haven't tested this on 3.2.x because upgrade
fails much earlier on db validation.
Line 264: handler.open()
Line 265: answer = False
Line 266: haveConfig = False
Line 267: proxyEnabled = handler.getParam('ENGINE_PROXY_ENABLED') == 'true'
--
To view, visit http://gerrit.ovirt.org/15051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib46bcf40acff860cd3e52634ade683d7a8836cf6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
