Alon Bar-Lev has posted comments on this change.
Change subject: engine: Integrate noVNC support
......................................................................
Patch Set 6: (2 inline comments)
....................................................
File packaging/services/ovirt-websocket-proxy.systemd.in
Line 4: [Service]
Line 5: Type=simple
Line 6: User=@ENGINE_USER@
Line 7: Group=@ENGINE_GROUP@
Line 8: LimitNOFILE=65535
Because of the nature of forking daemon please add:
LimitNPROC=2048
This will give us 2048 sessions by default.
Line 9: ExecStart=@ENGINE_USR@/services/ovirt-websocket-proxy.py $EXTRA_ARGS
start
Line 10:
Line 11: [Install]
....................................................
File packaging/services/ovirt-websocket-proxy.sysv.in
Line 31: echo $"Insufficient privilege" 1>&2
Line 32: exit 4
Line 33: fi
Line 34: echo -n $"Starting $PROG: "
Line 35: ulimit -n ${FILENO:-65535}
Because of the nature of forking daemon please add:
ulimit -u ${NPROC:-2048}
This will give us 2048 sessions by default.
Line 36: touch "${PIDFILE}"
Line 37: chown "${USER}" "${PIDFILE}"
Line 38: daemon --user "${USER}" --pidfile="${PIDFILE}" \
Line 39:
"${ENGINE_USR}/services/ovirt-websocket-proxy.py" \
--
To view, visit http://gerrit.ovirt.org/13931
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44e9870b88537360a1886e89c08f18865eae2ef0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Martin Beták <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
