Alon Bar-Lev has posted comments on this change.
Change subject: engine: Integrate noVNC support
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File packaging/services/ovirt-websocket-proxy.py
Line 85: self._key.verify_update(decoded[field].encode('utf8'))
Line 86: if self._key.verify_final(
Line 87: base64.b64decode(decoded['signature'])
Line 88: ) != 1:
Line 89: raise ValueError('Invalid signature')
Please add here a code to extract the time field out of the ticket and compare
it to current time with offset got from configuration, if less then accept, if
more than reject.
Line 90: return decoded['data']
Line 91:
Line 92:
Line 93: class Daemon(service.Daemon):
--
To view, visit http://gerrit.ovirt.org/13931
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44e9870b88537360a1886e89c08f18865eae2ef0
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Martin Beták <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
