Alissa Bonas has posted comments on this change.
Change subject: core: improve CDA of AddStorageServerConnection
......................................................................
Patch Set 1: Verified
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java
Line 61: public void updatePosixNonEmptyVFSType() {
Line 62: StorageServerConnections newPosixConnection =
createPosixConnection("multipass.my.domain.tlv.company.com:/export/allstorage/data1",
StorageType.POSIXFS, "nfs" , "timeo=30");
Line 63: parameters.setStorageServerConnection(newPosixConnection);
Line 64: parameters.setVdsId(Guid.Empty);
Line 65: parameters.setStoragePoolId(Guid.Empty);
there's a need to add assignment of storage pool id since the command now also
calls to super.canDoAction, and there's a validation there related to storage
pool id.
Line 66: doReturn(true).when(command).InitializeVds();
Line 67: CanDoActionTestUtils.runAndAssertCanDoActionSuccess(command);
Line 68: }
Line 69:
--
To view, visit http://gerrit.ovirt.org/15126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I00a46aac7d642128c287ef633c492f3c1b85f572
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
